On Fri, May 11, 2018 at 08:18:59AM +1000, Dave Chinner wrote: > On Fri, Apr 27, 2018 at 04:22:54PM +0800, Zorro Lang wrote: > > When test on large SCRATCH_DEV, grow a small XFS to huge size is a > > horrible thing (e.g grow 128m to 500T). So add a helper named > > _scratch_xfs_growfs_limited() to do below things: > > > > 1) If --large-fs is used, limit growfs size. > > 2) If a limit size parameter is specified, make sure growfs won't > > beyond this size. > > > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > > I think I originally just didn't run growfs tests like this on large > filesystems. i.e. require_no_largefs.... Hmm... Sorry, am I facing different review-points from 3 different XFS maintainers? ... Dave: require_no_largefs is better. Darrick: nearly ack this patch. Eric: 2018-04-27 04:03 < sandeen> [15:01] <zoro> [00:55:47] I think maybe use _require_no_large_scratch_dev for xfs/002 will be better. Grow a 128M XFS to large size is 'horrible' 2018-04-27 04:03 < sandeen> just limit growfs to something smaller. What should I do next? Thanks, Zorro > > Cheers, > > Dave. > > -- > Dave Chinner > david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
