On Thu, May 03, 2018 at 01:07:28AM -0400, Theodore Ts'o wrote: > The install-sh file is much more efficient than the libtool version > (50% faster wall clock time; much more than that when running in a > qemu emulation build environment). There doesn't seem to be any real > need for the libtool version, so bring back the original install-sh > script. > > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > --- > > A very large amount of time when running "make install" in a build > chroot using qemu emulation, such as constructed by running "sudo > setup-buildchroot --arch-armhf" using the script found here[1] is in > running the install-sh provided by libtool, which is amazing bloated > and forks a crazy number of processes to do something very simple. > > As near as I can tell there is zero benefit in using the install-sh > provided by libtool, so restore the version that SGI originally used. > > [1] https://github.com/tytso/xfstests-bld/blob/master/setup-buildchroot Does this break cross-compilation for chromeeOS? I ask, because that is why the hard coded install-sh was originally replaced by the libtool provided one last year: commit 5d20084fefaf09e86be26d7c71bd1c7ac2a2b35c Author: Gwendal Grignou <gwendal@xxxxxxxxxxxx> Date: Wed Apr 19 16:33:48 2017 -0700 build: allow cros-compilation on chromeOS - Request LIBTOOL to be used - Set topbuildir based on a Makefile variable to call libtool - Use /usr/local instead of /var for xfstest final location - Move macros from aclocal.m4 to acinclude.m4, aclocal.m4 is autogenerated. - Use autoconf variables @prefix@, @exec_prefix@. The regular way of compiling xfstests - make - remains. But it now runs autoreconf and libtoolize -i to produce a valid configure. Verified with 'make install --dry-run' that files are installed at the same place. Verified compiling in chromeOS chroot works as well. [eguan: resolve merge conflicts and update .gitignore and remove generated files by realclean] Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> Reviewed-by: Eryu Guan <eguan@xxxxxxxxxx> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
