On Tue, May 01, 2018 at 08:39:32AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > After we mess with logsunit and test that we can't mount the fs, repair > the filesystem to make sure that repair can deal with it. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > tests/xfs/439 | 1 + > 1 file changed, 1 insertion(+) > > > diff --git a/tests/xfs/439 b/tests/xfs/439 > index 215c4b90..9d5f6892 100755 > --- a/tests/xfs/439 > +++ b/tests/xfs/439 > @@ -79,6 +79,7 @@ fi > _check_dmesg _filter_assert_dmesg > > echo "Silence is golden" > +_scratch_xfs_repair >> $seqres.full 2>&1 But how should we check if repair does fix the corruption? I tried adding a "scratch_mount" after the repair and expected a success mount. But that mount also failed, and repair didn't report anything wrong in $seqres.full. Looks like the corruption was not detected nor repaired. [ 8278.679149] XFS (dm-1): Mounting V5 Filesystem [ 8278.679743] XFS (dm-1): log stripe unit 4095 bytes must be a multiple of block size [ 8278.680583] XFS (dm-1): AAIEEE! Log failed size checks. Abort! [ 8278.681817] XFS (dm-1): log mount failed Note that I was using latest for-next branch of xfsprogs. Thanks, Eryu > > # success, all done > status=0 > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
