On Sat, 2018-04-28 at 00:27 -0700, Amir Goldstein wrote: > On Fri, Apr 27, 2018 at 9:38 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > From: Jeff Layton <jlayton@xxxxxxxxxx> > > > > This adds a regression test for the following kernel patch: > > > > errseq: Always report a writeback error once > > > > This is motivated by some rather odd behavior done by the PostgreSQL > > project. The main database writers will offload the fsync calls to a > > separate process, which can open files after a writeback error has > > already occurred. > > > > This used to work with older kernels that reported the error to only > > one fd, but with the errseq_t changes we lost the ability to see > > errors that occurred before the open. The above patch restores that > > behavior. > > > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > > --- > > > > This patch currently fails on mainline kernels, but I'll be sending > > a pull request to Linus in the near future for the above patch. > > > > src/Makefile | 2 +- > > src/fsync-open-after-err.c | 167 +++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/999 | 95 ++++++++++++++++++++++++++ > > tests/generic/999.out | 3 + > > tests/generic/group | 1 + > > 5 files changed, 267 insertions(+), 1 deletion(-) > > create mode 100644 src/fsync-open-after-err.c > > create mode 100755 tests/generic/999 > > create mode 100644 tests/generic/999.out > > > > diff --git a/src/Makefile b/src/Makefile > > index 0d3feae1eeb2..3dc9b0da9c3a 100644 > > --- a/src/Makefile > > +++ b/src/Makefile > > @@ -15,7 +15,7 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \ > > holetest t_truncate_self t_mmap_dio af_unix t_mmap_stale_pmd \ > > t_mmap_cow_race t_mmap_fallocate fsync-err t_mmap_write_ro \ > > t_ext4_dax_journal_corruption t_ext4_dax_inline_corruption \ > > - t_ofd_locks > > + t_ofd_locks fsync-open-after-err > > > > LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ > > preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \ > > diff --git a/src/fsync-open-after-err.c b/src/fsync-open-after-err.c > > new file mode 100644 > > index 000000000000..3dcf936eb94a > > --- /dev/null > > +++ b/src/fsync-open-after-err.c > > Jeff, > > It is an anti pattern for xfstests to add a single purpose C program > for things that could be implemented otherwise. > > AFAICT, This program doesn't do anything that you cannot do with > existing bash helpers and existing programs. > > So either add a flag to fsync-err to enable the new test > or use xfs_io fsync (make sure it really returns the error) and > keep file open with bash tricks. > > Thanks, > Amir. Ok. Let's drop this patch for now and I'll see if I can code it up with scripts somehow. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
