[PATCH] fsync-err: don't truncate files on second open

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



From: Jeff Layton <jlayton@xxxxxxxxxx>

...and no need for O_CREAT flag.

Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
---
 src/fsync-err.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/fsync-err.c b/src/fsync-err.c
index 146688ddb01e..bd05dcc0a898 100644
--- a/src/fsync-err.c
+++ b/src/fsync-err.c
@@ -170,9 +170,9 @@ int main(int argc, char **argv)
 			ret = fsync(fd[i]);
 			if (ret < 0) {
 				/*
-				 * We did a failed write and fsync on each fd before.
-				 * Now the error should be clear since we've not done
-				 * any writes since then.
+				 * We did a failed write and fsync on each fd
+				 * before.  Now the error should be clear since
+				 * we've not done any writes since then.
 				 */
 				printf("Third fsync on fd[%d] failed: %m\n", i);
 				return 1;
@@ -220,7 +220,7 @@ int main(int argc, char **argv)
 			printf("Close of fd[%d] returned unexpected error: %m\n", i);
 			return 1;
 		}
-		fd[i] = open(fname, O_WRONLY | O_CREAT | O_TRUNC, 0644);
+		fd[i] = open(fname, O_WRONLY, 0644);
 		if (fd[i] < 0) {
 			printf("Second open of fd[%d] failed: %m\n", i);
 			return 1;
-- 
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux