On Mon, Apr 23, 2018 at 4:50 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Mon, Apr 23, 2018 at 6:37 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> On Wed, Apr 18, 2018 at 4:30 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>> On Wed, Apr 18, 2018 at 5:23 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >>>> On Wed, Apr 18, 2018 at 4:16 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>>> >>>>> FYI, Miklos has a patch set in review to fix the last of the >>>>> non-standard behavior tracking test that is still failing (overlay/016). >>>>> After that patch set is merged, all overlay tests will be expected to >>>>> pass on master - new era ;-) >>>> >>>> Oh, we can write new tests that don't pass ;) >> >> Another one: >> >> fstat() returns incorrect st_ctime after unlink of a lower file/directory. >> >> Alternative fixes: >> >> 1) take some attributes from whiteout >> >> 2) metacopy up to tmpfile >> >> But first of all, we need a test case that fails, otherwise there's no >> motivation to do the fix ;) >> > > I admit that the failing xfstests I wrote have had a "motivating" > effect, but going forward, I feel that xfstests is not really the place > for these sort of weird behavior tests. I find it to be more suiting as > a regression tracking test suite and special test case coverage. > > IMO, parent ctime fits better to a POSIX compliance test suite, such > as pdjfstest. I'm not talking about parent ctime, rather victim ctime (updated due to nlink change). > > And besides, overlayfs now feels it is in a functional state that is worthy > of PASS. Sure, that is a very subjective observation. > >> I'm wondering, would it make sense to manually add "rotation points" >> to plain xfstest test cases? > > Can you give an example of an xfstest and a rotation point? Any test where there is a setup phase and a test phase is asking for a rotation point (i.e. set up on lower (no-overlay) and then modify on overlay). I haven't thought about individual test cases, just wondering if there's already a testcase testing st_ctime on unlink for example, that is only not failing because there isn't a rotation of overlay after the setup phase. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
