On Fri, Apr 13, 2018 at 11:42:10PM +1000, Dave Chinner wrote:
> On Fri, Apr 13, 2018 at 12:36:12PM +0800, Eryu Guan wrote:
> OK, I got your point now, it's a bug in a diagnostic tool that is only used by XFS developers as a test infrastructure, so we can
> treat it as a infrastructure dependency as all other _require rules. I think that makes sense in this case. Thanks for
> the explanation!
> yang xu, would you mind sending a v2 patch as Dave suggested? Thanks!
> Eryu
Hi Eryu
I will send a v2 patch as Dave suggested.
Thanks
Yang Xu
>
> Yes, it's ialso fixed in recent version of xfsprogs, but you know very
> well that we test distros that have ancient xfsprogs and will never
> have this issue fixed in them. We use detectiona nd notrun to avoid
> tests they should not run all the time, and I don't see how this is
> any different.
>
> I really don't understand why you are pushing back on this - why
> should this specific infrastructure deficiency cause test failures,
> when all the existing infrastructure support checks cause tests to
> notrun rather than fail?
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
?韬{.n?????%??檩??w?{.n???赚断??n?■???h?璀?｛?夸z罐?+€?zf＂?????i?????_璁?:+v??撸?
