Sorry for the previous reply in HTML format which is not delivered to the mail list. I mean there is already xfstests generic/405 for the situation. Thin provision devices need to call dmsetup to setup. I wonder If calling dmsetup in progs tests is acceptable or not. If it is, I will do it. Thanks, Su On Mon, Apr 9, 2018 at 9:25 PM, David Sterba <dsterba@xxxxxxx> wrote: > On Tue, Apr 03, 2018 at 04:39:45PM +0800, Su Yue wrote: >> when mkfs.btrfs on a thin provision device which has very small >> backing size and big virtual size, all code works well in >> mkfs.btrfs until close_ctree() is called. >> close_ctree() fails to sync device due to small backing size >> while closing devices. >> However, mkfs returns 0 in such situation which causes failure of >> xfstests generic/405. >> >> So, let mkfs returns nonzero value if previous steps succeeded but >> close_ctree() failed. >> Then xfstests generic/405 passes now. >> >> Signed-off-by: Su Yue <suy.fnst@xxxxxxxxxxxxxx> > > Applied, thanks. Can you please write a test for that? > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html