On 3 Apr 2018, at 5:45, Christoph Hellwig wrote: > On Thu, Mar 29, 2018 at 11:34:39AM -0400, Benjamin Coddington wrote: >> We'd like to run generic tests for NFS, but often have slightly different >> output for our results. One instance is that for the NFS client the >> removal of an open file or directory is handled differently than for a >> local filesystem. We can expect nlink to be 1 for files, and to receive >> -ESTALE for operations on deleted directories, isn't that silly? > > NFS is simply buggy in this case, and we should at least xfail the test > case, not make it look fine. No, having nlink == 1 is not a bug and we should expect that behavior, the same with the -ESTALE return for a directory. This is true, at least, for the linux client. > I'd rather have a file that lists expected fails per file system with an > explanation than a hack like this that papers over the issue. I'd like that as well, since there are a number of tests that just don't make sense at all for NFS.. I'll figure out a way to do that. We have groups of tests right now, and NFS is one, but those seem to be tests that should be run only by NFS. Ben -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
