Hi Filipe, I tried running the xfstest above on kernel 4.15.0 and I haven't been able to hit the bug. The xfstest passes clean for me. I compared the btrfs-debug-tree in my case with the one attached by Eryu, and I see I do not have any xattr as he does. However, for every run of the xfstest, the extent tree info that I get from btrfs-debug-tree has varying number of items in the first leaf node. (I have attached two dump files for your reference.) I also tried changing the offset at which fpunch is performed to match the offset of the last extent in the first leaf of the extent tree - however the md5 before and after crash was the same. Could you give more details on this? https://friendpaste.com/1wVAz7hG0U5SgYtZavbJhL https://friendpaste.com/1wVAz7hG0U5SgYtZavxALg Thanks, Jayashree Mohan On Thu, Mar 29, 2018 at 8:45 AM, Filipe Manana <fdmanana@xxxxxxxxxx> wrote: > On Wed, Mar 28, 2018 at 11:33 AM, Eryu Guan <guaneryu@xxxxxxxxx> wrote: >> On Wed, Mar 28, 2018 at 09:48:17AM +0100, Filipe Manana wrote: >>> On Wed, Mar 28, 2018 at 3:17 AM, Eryu Guan <guaneryu@xxxxxxxxx> wrote: >>> > On Mon, Mar 26, 2018 at 11:59:21PM +0100, fdmanana@xxxxxxxxxx wrote: >>> >> From: Filipe Manana <fdmanana@xxxxxxxx> >>> >> >>> >> Test that when we have the no-holes mode enabled and a specific metadata >>> >> layout, if we punch a hole and fsync the file, at replay time the whole >>> >> hole was preserved. >>> >> >>> >> This issue is fixed by the following btrfs patch for the linux kernel: >>> >> >>> >> "Btrfs: fix fsync after hole punching when using no-holes feature" >>> > >>> > I'd expect a test failure with 4.16-rc6 kernel, as the mentioned fix >>> > above is not there. But test always passes for me. Did I miss anything? >>> > btrfs-progs version is btrfs-progs-4.11.1-3.fc27. >>> >>> It should fail on any kernel, with any btrfs-progs version (which >>> should be irrelevant). >>> Somehow on your system we are not getting the specific metadata layout >>> needed to trigger the issue. >>> >>> Can you apply the following patch on top of the test and provide the >>> result 159.full file? >>> >>> https://friendpaste.com/6xAuLeN4xl1AGjO9Qc5I8L >>> >>> So that I can see what metadata layout you are getting. >>> Thanks! >> >> Sure, please see attachment. > > Thanks! > So you indeed get a different metadata layout, and that is because you > have SELinux enabled which causes some xattr to be added to the test > file (foobar): > > item 6 key (257 XATTR_ITEM 3817753667) itemoff 64932 itemsize 83 > location key (0 UNKNOWN.0 0) type XATTR > transid 7 data_len 37 name_len 16 > name: security.selinux > data unconfined_u:object_r:unlabeled_t:s0 > > I can make the test work with and without selinux enabled (by punching > holes on a few extents that are candidates to be at leaf boundaries). > Is it worth it? (I assume most people run the tests without selinux) > > thanks > >> >> Thanks, >> Eryu > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
