[PATCH] xfs/278: mkfs with v4 format

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



This test had silently stopped working when mkfs.xfs switched
to v5 supers by default, and changed inode sizes:

> field u not found
> parsing error
> field u not found
> parsing error

...

Switch back to the original behavior by turning off crcs,
and catch such failures if they crop up again by looking
for xfs_db errors in $seqres.full.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

(is it horrific to grep $seqres.full?  xfs_db doesn't exit
with failure in this case :( )

and now this causes repair to fail on a verifier error, but
I just sent an xfsprogs patch to fix that as well.

diff --git a/tests/xfs/278 b/tests/xfs/278
index b94ee9c..c0e09c7 100755
--- a/tests/xfs/278
+++ b/tests/xfs/278
@@ -48,7 +48,7 @@ _supported_os Linux
 _require_scratch
 
 rm -f $seqres.full
-_scratch_mkfs >$seqres.full 2>&1
+_scratch_mkfs -m crc=0 -n ftype=0 >$seqres.full 2>&1
 _scratch_mount
 
 mkdir -p $SCRATCH_MNT/dir/subdir
@@ -73,6 +73,8 @@ _scratch_xfs_db -x -c "inode $DIR_INO" -c "write core.nlinkv2 0"  >> $seqres.ful
 _scratch_xfs_db -x -c "inode $SUBDIR_INO" -c "write u.sfdir2.hdr.parent.i4 0"  >> $seqres.full
 _scratch_xfs_db -x -c "inode $SUBDIR_INO" -c "write core.nlinkv2 0"  >> $seqres.full
 
+grep -q "not found\|parsing error" $seqres.full && _fail "xfs_db commands failed"
+
 echo "===== BEGIN of xfs_repair =====" >> $seqres.full
 echo "" >>$seqres.full
 

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux