On Fri, Feb 23, 2018 at 12:16:32PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Currently a test passes even if it leaves a corrupt filesystem > behind, or a splat in the system logs that should not be there. > Rework the check code to consider these as test failures so they can > be accounted and tracked correctly. This also allows us to include > the post-test filesystem checking in the test runtime - that is > currently not accounted to the test, either, so the real runtime of > each test is not accurately reflected in the time stats being > reported. > > This requires a complete reworking of the main test check loop. It's > a bunch of spaghetti at the moment because it has post test > reporting code preventing use from using continue when a test is > done. Move that post test reporting to the start of the next loop > iteration and clean up the code to use continues where appropriate. > > Also, for cases where we haven't run the test or it's already been > marked as failed, don't bother running the filesystem/dmesg checks > for failure as we're already going to report the test as failed. > > This touches almost all of the loop, so get rid of the remaining > 4 space indents inside the loop while moving all this code around. > > Signed-Off-By: Dave Chinner <dchinner@xxxxxxxxxx> Thanks for the rework! It needs careful testing and most probably won't catch this week's update. I'll take it in next week if I see no problems in testing. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
