On 13 February 2018 at 10:12, Eryu Guan <eguan@xxxxxxxxxx> wrote: > Hi all, > > This is an RFC patchset that follows Andreas Gruenbacher's recent post > "Failing scratch mounts"[1]. It changes _scratch_mount to call _fail on > mount failure by default, so that when the mount fails, the tests won't > write to the underlying filesystem and fail in implicit way, which > sometimes makes debugging harder to do. > > Also introduce a new _scratch_mount_nocheck helper, which mount scratch > device and doesn't check the mount status, for tests that need to check > mount status themselves. > > This two-patch patchset should really be one patch, but for easy review, > I split the patch into two pieces, the first patch introduce the new > _scratch_mount_nocheck helper and converts _scratch_mount usages in > common dir, the second patch converts all the tests (which can be > tedious). > > I've tested it by running full '-g auto' tests against xfs/xfs with > reflink/ext4/btrfs and I didn't see any new failures. > > (Note that I based this patchset against fstests release on Feb. 4th, so > I didn't convert the new tests release on Feb. 11th. And as this is an > RFC, I didn't write detailed commit log in each patch.) These patches do fix the scratch mount problems I've been seeing on gfs2. Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
