Re: [PATCH v2 6/8] fssum: Use bswap_64() instead of __bswap_64()

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



> On Jan 22, 2018, at 10:26 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> 
> On Mon, Jan 22, 2018 at 03:57:17PM +0000, Rostislav Skudnov wrote:
>> Macros and functions starting with two underscores are usually internal
>> and shouldn't be used by applications when a version without "__" is
>> available.
>> 
>> Include byteswap.h explicitly since bswap_64() is defined there.
> 
> Shouldn't this use htobe64 instead?

Hello, Cristoph.

Thanks for your feedback! We can of course use htobe64(), but the file
src/fssum.c already defines htonll() in a way that takes endianness into
account, and using htobe64() would be equivalent to htonll(). My strategy when
writing this patch set was to make the least number of modifications required
to build with musl libc.--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux