On Thu, Jan 18, 2018 at 01:21:25PM +0100, Jan Kara wrote: > Omar's problem is actually that he had no quota format enabled so tools > failed miserably to enable quotas although xfstests thought quota should be > available. That could be viewed as a bug in _require_quota() macro in xfstests > but OTOH userspace has no way of knowing which quota formats are available > - it can only try to enable quota on a particular fs and that either fails > or not. So implementing proper _require_quota() macro would mean you have > to do full quota setup for some filesystem, try to enable quotas, and see if > that fails. Doable but frankly I'm not hugely interested in that for such a > cornercase... Yes, I'd much rather fix it in Kconfig. The question I was asing is really whether we could start deprecating QFMT_V1 by requiring QFMT_V2 and making QFMT_V1 the only optional format, and then changing the tools to strongly bias the user towards using V2 --- and maybe making it be impossible to create new QFMT_V1 format quota files at all at some point. It will take a while --- years no doubt --- but a journey of ten thousand miles starts with a single step, as the saying goes. - Ted -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
