On Fri, Jan 12, 2018 at 02:16:23PM +0800, xiao yang wrote: > If log stripe unit isn't a multiple of the fs blocksize and mounting, > the invalid sb_logsunit leads to crash as soon as we try to write to > the log. > > Signed-off-by: xiao yang <yangx.jy@xxxxxxxxxxxxxx> > --- > tests/xfs/437 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/xfs/437.out | 2 ++ > tests/xfs/group | 1 + > 3 files changed, 76 insertions(+) > create mode 100755 tests/xfs/437 > create mode 100644 tests/xfs/437.out > > diff --git a/tests/xfs/437 b/tests/xfs/437 > new file mode 100755 > index 0000000..f2b84ad > --- /dev/null > +++ b/tests/xfs/437 > @@ -0,0 +1,73 @@ > +#! /bin/bash > +# FS QA Test No. 437 > +# > +# Regression test for commit: > +# 9c92ee2 ("xfs: validate sb_logsunit is a multiple of the fs blocksize") > +# > +# If log stripe unit isn't a multiple of the fs blocksize and mounting, > +# the invalid sb_logsunit leads to crash as soon as we try to write to > +# the log. > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2018 FUJITSU. All Rights Reserved. > +# Author: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > + > +seq=`basename "$0"` > +seqres="$RESULT_DIR/$seq" > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + rm -rf $tmp.* > +} > + > +# get standard environment and checks > +. ./common/rc > + > +# real QA test starts here > +_supported_os Linux > +_supported_fs xfs > +_require_scratch This test triggers ASSERT failure and warning on debug build, thus failed _dmesg_check, I think we need _disable_dmesg_check (and some comments) too. [1809960.157615] XFS (sda6): log stripe unit 4095 bytes must be a multiple of block size [1809960.159228] XFS (sda6): AAIEEE! Log failed size checks. Abort! [1809960.160534] XFS: Assertion failed: 0, file: fs/xfs/xfs_log.c, line: 679 [1809960.162298] WARNING: CPU: 1 PID: 2186 at fs/xfs/xfs_message.c:105 asswarn+0x1e/0x30 [xfs] > + > +rm -f "$seqres.full" > + > +# Format > +_scratch_mkfs > $seqres.full 2>&1 || _fail "mkfs failed" > + > +# Set logsunit to a value which is not a multiple of the fs blocksize > +blksz=$(_scratch_xfs_get_sb_field blocksize) > +_scratch_xfs_set_sb_field logsunit $((blksz - 1)) >> $seqres.full 2>&1 \ > + || _notrun "failed to set sb_logsunit" It seems xfs_db doesn't return non-zero on failure, so _notrun won'be be triggered, you may want to read the logsuint value again to see if it's set correctly. > + > +# Mount and writing log may trigger a crash > +if _scratch_mount >> $seqres.full 2>&1; then Better to mention that with the fix applied kernel refuses to mount, so we know a mount failure is expected. > + for i in $(seq 1 1000); do > + touch ${SCRATCH_MNT}/$i echo > ${SCRATCH_MNT}/$i might be faster Thanks, Eryu > + done > + _scratch_unmount > +fi > + > +echo "Silence is golden" > + > +# success, all done > +status=0 > +exit > diff --git a/tests/xfs/437.out b/tests/xfs/437.out > new file mode 100644 > index 0000000..4dcb607 > --- /dev/null > +++ b/tests/xfs/437.out > @@ -0,0 +1,2 @@ > +QA output created by 437 > +Silence is golden > diff --git a/tests/xfs/group b/tests/xfs/group > index d230060..35d1b03 100644 > --- a/tests/xfs/group > +++ b/tests/xfs/group > @@ -434,3 +434,4 @@ > 434 auto quick clone fsr > 435 auto quick clone > 436 auto quick clone fsr > +437 auto quick log dangerous > -- > 1.8.3.1 > > > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html