On Thu, Dec 28, 2017 at 07:49:31PM +0800, zhangyi (F) wrote: [..] > +# Test orphan whiteout in lower and upper layer, should remove > +echo "+ Orphan whiteout" > +make_whiteout $lowerdir/foo > +make_whiteout $upperdir/foo > +make_whiteout $upperdir/bar > + > +_overlay_fsck_dirs $lowerdir $upperdir $workdir -p >> $seqres.full 2>&1 || \ > + _fail "fsck should not fail" I ran fsck.overlay manually (V3 patches) with one orphan whiteout in upper. I get following output. fsck.overlay -o lowerdir=lower,upperdir=upper,workdir=work Orphan whiteout: /root/fsck-overlay-testing/upper/foo Remove ? [y]: y fsck.overlay:[Error]: Cannot getxattr /root/fsck-overlay-testing/upper/foo trusted.overlay.origin: No such file or directory Filesystem clean This message about "overlay.origin" not being there, should not be an error. You have already figured out, its an orphan whiteout, and user already asked you to remove it. So checking or origin after that can calling it Error might not make much sense. Also on top, later I get "Filesystem clean". I think in this case, user should not see any message until and unless a error actually has happened which prevents from cleaning orphan whiteout. Vivek -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
