Re: [PATCH v7] generic: initial fiemap range query test

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Dec 05, 2017 at 04:24:06PM +0800, Eryu Guan wrote:
> On Thu, Nov 30, 2017 at 06:05:27PM +0200, Nikolay Borisov wrote:
> > Fiemap gained support for passing in optional offset len
> > which denote the range requested, so this patch adds
> > testcases for this functionality. Aditionally, a special "ranged"
> > argument is added to the require_xfs_io_command which checks
> > for the presence of fiemap range support.
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>
> > ---
> > 
> > For the time being this test is expected to fail on XFS. 
> > 
> > V7: 
> >  * Adjusted for 64k block size filesystem
> >  * Only use/require a test device and not a scratch device
> 
> v7 looks good to me, test passes on ppc64 hosts too, thanks!
> 
> But it seems that it's not decided yet whether xfs should trim the
> ranged fiemap query request, I'd like to see the expected behavior
> decided first. (BTW, v7 passes with latest RHEL7 kernel too, seems
> extents are not trimmed there.)

The iomap callers need to tell iomap_apply if they want exactly the
range they asked for and no more (most of the write paths) or if they
can handle outside ranges (fiemap), and then we can turn on
XFS_BMAPI_ENTIRE reporting in xfs_iomap_begin.

--D

> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux