Adding fstests list and maintainer in CC, because this is where this
patch in meant to go.
Eryu,
This test is expected to fail with overlayfs on current upstream and
any past version
AFAIK.
Do you this it qualifies for a specific overlay/* regression test? or
that generic/* test
would be sufficient to cover the overlayfs issue?
On Thu, Nov 30, 2017 at 4:43 AM, Chengguang Xu <cgxu@xxxxxxxxxxxx> wrote:
> generic/470 should be skipped when delalloc is not supported.
>
Test looks very good. One minor nit below.
Not sure why you choose the minor detail in the line above as the
commit description?
Seems like the text in the top comment of the test would have been also
appropriate for commit description.
> Signed-off-by: Chengguang Xu <cgxu@xxxxxxxxxxxx>
> ---
> tests/generic/470 | 133 ++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/470.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 136 insertions(+)
> create mode 100755 tests/generic/470
> create mode 100644 tests/generic/470.out
>
> diff --git a/tests/generic/470 b/tests/generic/470
> new file mode 100755
> index 0000000..a43fb91
> --- /dev/null
> +++ b/tests/generic/470
> @@ -0,0 +1,133 @@
> +#! /bin/bash
> +# FS QA Test No. 470
> +#
> +# Run fsync & fdatasync & syncfs & sync to test sync result.
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2017 Chengguang Xu <cgxu@xxxxxxxxxxxx>. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=0
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +
> +# Modify as appropriate.
> +_supported_fs generic
> +_supported_os Linux
> +_require_test
> +_require_xfs_io_command "fsync"
> +_require_xfs_io_command "fdatasync"
> +_require_xfs_io_command "syncfs"
> +_require_xfs_io_command "sync"
> +_require_command "$FILEFRAG_PROG" filefrag
> +
> +PREFIX=$TEST_DIR/${seq}-testfile
> +TESTFILES=$TEST_DIR/${seq}-testfile-*
> +FCNT=1000
> +
> +write_data()
> +{
> + rm -f $TESTFILES >/dev/null 2>&1
> + for i in `seq 1 $FCNT`; do
> + $XFS_IO_PROG -f -c "pwrite 1K 1K" \
> + ${PREFIX}-$i >/dev/null 2>&1
> + done
> +}
> +
> +check_delalloc_support()
> +{
> + write_data
> + $FILEFRAG_PROG -e $TESTFILES | grep -w delalloc >/dev/null 2>&1
> + if [ $? -ne 0 ]; then
> + _notrun "This test requires delayed allocation support!"
> + fi
> +}
> +
> +sync_data()
> +{
> + case $1 in
> + sync)
> + $XFS_IO_PROG -c "sync" >/dev/null 2>&1
> + ;;
> + syncfs)
> + $XFS_IO_PROG -c "syncfs" ${PREFIX}-${FCNT} >/dev/null 2>&1
> + ;;
> + fsync)
> + for i in `seq 1 $FCNT`; do
> + $XFS_IO_PROG -c "fsync" ${PREFIX}-${i} >/dev/null 2>&1
> + done
> + ;;
> + fdatasync)
> + for i in `seq 1 $FCNT`; do
> + $XFS_IO_PROG -c "fdatasync" ${PREFIX}-${i} >/dev/null 2>&1
> + done
> + ;;
> + *)
> + ;;
> + esac
> +}
> +
Technically, you don't need all those cases.
This command will do almost the same for all cases and more efficiently
then the for loop.
$XFS_IO_PROG -c $sync_mode ${PREFIX}-* >/dev/null 2>&1
sync happens only once, but files are being opened for no reason.
syncfs happens FCNT times, but that won't change test result.
So up to you if you use this hack for all modes, but I would certainly
change fsync and fdatasync to not use the for loop as xfs_io already
has a built in file iterator.
Thanks!
Amir.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
