On Tue, Nov 14, 2017 at 3:10 AM, Misono, Tomohiro <misono.tomohiro@xxxxxxxxxxxxxx> wrote: > Modify filter in order make the test run correctly for > both old (2.29) and new (2.30) util-linux. > > Signed-off-by: Tomohiro Misono <misono.tomohiro@xxxxxxxxxxxxxx> > --- > tests/overlay/035 | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/overlay/035 b/tests/overlay/035 > index 64fcd708..6f1627c6 100755 > --- a/tests/overlay/035 > +++ b/tests/overlay/035 > @@ -69,7 +69,8 @@ mkdir -p $lowerdir1 $lowerdir2 $upperdir $workdir > $MOUNT_PROG -t overlay -o"lowerdir=$lowerdir2:$lowerdir1" \ > $OVL_BASE_SCRATCH_MNT $SCRATCH_MNT > touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch > -_scratch_remount rw 2>&1 | _filter_scratch > +_scratch_remount rw 2>&1 | _filter_scratch \ > + | sed -e "s,SCRATCH_MNT: ,," | sed -e "s,\.$,," > $UMOUNT_PROG $SCRATCH_MNT > This change doesn't look right and/or not explained properly. Any change to accommodate tool differences should be done in the filter helpers, not in an individual test that filters the output of a generic helper. What is the change 2.29 -> 2.30 that causes the problem? Without mentioning this, it is really hard to review if your change is correct. Amir. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
