On Thu, Nov 02, 2017 at 03:14:45PM +0200, Amir Goldstein wrote: > On Thu, Nov 2, 2017 at 2:42 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > > On Wed, Nov 01, 2017 at 02:47:23PM -0700, Darrick J. Wong wrote: > >> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > >> > >> A directory corrupted into a symlink will be caught by the upcoming > >> local format ifork verifiers. > >> > >> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > >> --- > >> tests/xfs/348.out | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> > >> diff --git a/tests/xfs/348.out b/tests/xfs/348.out > >> index f4a7a71..17d9be2 100644 > >> --- a/tests/xfs/348.out > >> +++ b/tests/xfs/348.out > >> @@ -239,7 +239,7 @@ would have junked entry "DATA" in directory PARENT_INO > >> would have junked entry "DIR" in directory PARENT_INO > >> would have junked entry "EMPTY" in directory PARENT_INO > >> would have junked entry "FIFO" in directory PARENT_INO > >> -stat: 'SCRATCH_MNT/test/DIR' is a symbolic link > >> +stat: cannot stat 'SCRATCH_MNT/test/DIR': Structure needs cleaning > > > > But this breaks tests on old kernels. Or with the new ifork verifiers, > > old kernels can be considered as buggy? > > > > Can filter new and old error into canonicalized string. > Dodgy, bug we've done it before. > See: > git grep sed | grep 'Operation not permitted\|Permission denied' I tried that, but the "stat: XXX is a symbolic link" message comes from a different path in the test file code. Unless... you're suggesting that I should sed the error output to make it look like the previous (broken) output? --D > > Amir. > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
