On 27.10.2017 15:46, Eryu Guan wrote: > On Fri, Oct 27, 2017 at 03:37:12PM +0300, Nikolay Borisov wrote: >> Since xfs_io's fiemap implementation was changed to explicitly show a whole >> when a file consists only of it adjust the output of various test accordingly. >> Essentially only test 1 and 10 of _test_generic_punch require changes >> >> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx> >> --- >> tests/generic/012.out | 1 + >> tests/generic/016.out | 1 + >> tests/generic/021.out | 2 ++ >> tests/generic/022.out | 2 ++ >> tests/generic/058.out | 1 + >> tests/generic/060.out | 1 + >> tests/generic/061.out | 1 + >> tests/generic/063.out | 1 + >> tests/generic/255.out | 6 ++++++ >> tests/generic/316.out | 6 ++++++ >> 10 files changed, 22 insertions(+) >> >> diff --git a/tests/generic/012.out b/tests/generic/012.out >> index ffbf8a3..8045471 100644 >> --- a/tests/generic/012.out >> +++ b/tests/generic/012.out >> @@ -1,5 +1,6 @@ >> QA output created by 012 >> 1. into a hole >> +0: [0..95]: hole > > I suspect this will break test runs with old xfs_io too (and again, I > haven't confirmed yet..). Perhaps we need some kind of filter? You are right it will indeed break with old xfs_io so some solution need to be created. At this time I'm more interested to see if people will accept the fiemap code and if there is agreement I will focus on creating such a filter. > > Thanks, > Eryu > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
