On Wed, Sep 27, 2017 at 04:39:20PM -0500, Goldwyn Rodrigues wrote: > > > On 09/27/2017 04:34 PM, Dave Chinner wrote: > > On Wed, Sep 27, 2017 at 02:10:02PM -0500, Goldwyn Rodrigues wrote: > >> From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > >> > >> Tests the RWF_NOWAIT flag so the I/O returns immediately on > >> a new file, without any block allocations. > >> > >> A new program which includes the pwritev2() call is used. This allows > >> passing flags for the I/O to be performed. > > > > Rather than write a one-off test program for this that effectively > > replicates xfs_io pread/pwrite functionality, please add RWF_NOWAIT > > flag support to xfs_io. > > > > This one off program is required because xfs_io does not support partial > writes. It tries to do that within the loop and does not return the > number of bytes written. This is required for test generic/462. Then please also extend xfs_io to support partial reads and writes in the manner you need. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html