Re: xfs/310: relax extent count check

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Sep 18, 2017 at 07:28:59PM -0700, Darrick J. Wong wrote:
> On Sun, Sep 03, 2017 at 05:51:01PM +0200, Christoph Hellwig wrote:
> > If we got over the bmbt length we'll always allocate two extents,
> > its just that so far getbmap merged them.
> > 
> > Also fix/update some comments.
> > 
> 
> Needs a s-o-b.  Otherwise,

I can fix it up.

> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Thanks for reviewing!

Eryu

> 
> --D
> 
> > diff --git a/tests/xfs/310 b/tests/xfs/310
> > index c78f6f1..f33a15a 100755
> > --- a/tests/xfs/310
> > +++ b/tests/xfs/310
> > @@ -1,7 +1,7 @@
> >  #! /bin/bash
> >  # FS QA Test No. 310
> >  #
> > -# Create a file with more than 2^21 extents (the max length of a bmbt record).
> > +# Create a file with more than 2^21 blocks (the max length of a bmbt record).
> >  #
> >  #-----------------------------------------------------------------------
> >  # Copyright (c) 2016, Oracle and/or its affiliates.  All Rights Reserved.
> > @@ -75,8 +75,9 @@ mkdir $testdir
> >  blksz="$(_get_block_size $testdir)"
> >  $XFS_IO_PROG -f -c "falloc 0 $((nr_blks * blksz))" $testdir/file1 >> $seqres.full
> >  
> > +# make sure the allocator didn't allocate more than the needed two extents
> >  echo "Check extent count"
> > -xfs_bmap -l -p -v $testdir/file1 | grep '^[[:space:]]*1:' -q && xfs_bmap -l -p -v $testdir/file1
> > +xfs_bmap -l -p -v $testdir/file1 | grep '^[[:space:]]*2:' -q && xfs_bmap -l -p -v $testdir/file1
> >  inum=$(stat -c '%i' $testdir/file1)
> >  umount $SCRATCH_MNT
> >  
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux