Re: [PATCH v4 5/5] fsx: add support for keeping existing file

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Sep 07, 2017 at 03:38:59PM +0300, Amir Goldstein wrote:
> On Thu, Sep 7, 2017 at 10:26 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> > With fsx -k, do not truncate existing file and use its size as upper
> > bound on file size.
> >
> > This is needed to prevent fsx from truncating the file on start of
> > test when testing fsx on cloned files.
> >
> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> > ---
> 
> > -       if (lite) {
> > +       if (!(o_flags & O_TRUNC)) {
> >                 off_t ret;
> > -               file_size = maxfilelen = lseek(fd, (off_t)0, SEEK_END);
> > +               file_size = maxfilelen = biggest = lseek(fd, (off_t)0, SEEK_END);
> > +               prt("file_size is %lu\n", file_size);
> 
> Eryu,
> 
> Please remove this added debug log before merging.
> It breaks expected output of test generic/127

Sure, thanks for the heads-up.

Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux