On Tue, Sep 5, 2017 at 1:50 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > On Wed, Aug 30, 2017 at 05:51:41PM +0300, Amir Goldstein wrote: >> -g X: write character X instead of random generated data >> >> This is useful to compare holes between good and bad buffer. >> >> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > This seems useful, but I don't see this option gets used in this > patchset. Perhaps introduce it when it gets used in the test? I used it for debugging, to compare hexdump of good and bad files when I suspected that checksum errors were due to different zeroed ranges. > >> --- >> ltp/fsx.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/ltp/fsx.c b/ltp/fsx.c >> index dd6b637..a75bc55 100644 >> --- a/ltp/fsx.c >> +++ b/ltp/fsx.c >> @@ -132,6 +132,7 @@ unsigned long simulatedopcount = 0; /* -b flag */ >> int closeprob = 0; /* -c flag */ >> int debug = 0; /* -d flag */ >> unsigned long debugstart = 0; /* -D flag */ >> +char filldata = 0; /* -g flag */ >> int logid = 0; /* -j flag */ >> int flush = 0; /* -f flag */ >> int do_fsync = 0; /* -y flag */ >> @@ -817,6 +818,8 @@ gendata(char *original_buf, char *good_buf, unsigned offset, unsigned size) >> good_buf[offset] = testcalls % 256; >> if (offset % 2) >> good_buf[offset] += original_buf[offset]; >> + if (filldata) >> + good_buf[offset] = filldata; > > If filldata is not null, we're wasting cycles setting good_buf[offset] > and overwriting it with filldata. Use a if-else switch? e.g. > considering this is a debugging option that is not meant to optimize performance, I don't think that's critical, but I can fix that. Thanks Amir. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
