On Tue, Sep 5, 2017 at 1:46 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > On Wed, Aug 30, 2017 at 05:51:39PM +0300, Amir Goldstein wrote: >> When writing the intermixed output of several fsx processes >> to a single log file, it is usefull to prefix logs with a log id. >> Use fsx -j <logid> to define the log messages prefix. > > Would it be better to allow any string as prefix, not limit to id > number? > Maybe, but I didn't see an immediate need for that beyond the concurrent test runs, for with numeric id is sufficient. Besides, the function that prepends the prefix, prt() is sometimes uses for continued line, which results with weird looking lines like this one: 1: 60( 60 mod 256): 1: FALLOC 0x30140 thru 0x30f3c (0xdfc bytes) 1: EXTENDING1: So it's not really worth fixing properly, but anything more then a single numeric prefix is going to look quite bad. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
