[PATCH] generic/420: truncate testfile before executing the test

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



If generic/437 is run before generic/420, the latter fails with:

  4c4
  < stat.size = 2048
  ---
  > stat.size = 2097152

because both use $TEST_DIR/testfile.  generic/437 leaves it at 2M,
while generic/420 assumes that it is empty (or at least smaller than
2048 bytes).

Use a private test file (testfile.$seq) and truncate it on open just in
case.

Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx>
---
 tests/generic/420 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/generic/420 b/tests/generic/420
index ccb6cb8e829b..aab2e08855d0 100755
--- a/tests/generic/420
+++ b/tests/generic/420
@@ -52,10 +52,10 @@ _supported_os Linux
 _require_test
 _require_xfs_io_command fpunch
 
-testfile="${TEST_DIR}/testfile"
+testfile="${TEST_DIR}/testfile.$seq"
 
 echo "Testing fallocate(mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE)"
-$XFS_IO_PROG -fc "pwrite -b 2048 0 2048" $testfile | head -n1
+$XFS_IO_PROG -f -t -c "pwrite -b 2048 0 2048" $testfile | head -n1
 # fpunch from xfs_io has KEEP_SIZE flag set
 $XFS_IO_PROG -c "fpunch 2048 2048" $testfile
 $XFS_IO_PROG -c "stat" $testfile | grep -F 'stat.size'
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux