On Fri, Aug 25, 2017 at 08:29:06AM +0200, Ilya Dryomov wrote:
> On Fri, Aug 25, 2017 at 7:31 AM, Eryu Guan <eguan@xxxxxxxxxx> wrote:
> > On Thu, Aug 24, 2017 at 02:48:26PM +0200, Ilya Dryomov wrote:
> >> lvm utility in Ubuntu 14.04 LTS treats -l 100%FREE as a hard number and
> >> not as an approximate upper limit. With ~5G scratch partition and ~128M
> >
> > I just looked for an Ubuntu 14.04 LTS box and confirmed lvcreate does
> > support '-l 100%FREE'. Even on distributions as old as RHEL6 support
> > this usage too. Perpahs there were other things went wrong in your test
> > environment?
>
> The syntax is supported, but the semantics are different. Compare
> lvcreate(8) man pages on Ubuntu 14.04 LTS and something more recent:
>
> "When expressed as a percentage, the number is treated as an
> approximate upper limit for the total number of physical extents
> to be allocated (including extents used by any mirrors, for example)."
>
> In the example I gave, '-l 100%FREE' translates to 1310 PEs on Trusty
> vs ~60 PEs on a recent Fedora.
Ah, I got what you mean now. It seems a behavior change introduced by
lvm2 commit 4b6e3b5e5ea6 ("allocation: Allow approximate allocation when
specifying size in percent").
Then this patch looks fine to me (I probably will update the commit log
a bit to mention this lvm behavior change). Thanks!
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
