>
> I think adding a _require_no_xfs_debug helper in common/xfs and calling
> it in the new test should work (please rename if you have a better
> name), e.g.
>
> _require_no_xfs_debug()
> {
> if grep -q "debug 1" /proc/fs/xfs/stat; then
> _notrun "Require XFS built without CONFIG_XFS_DEBUG"
> fi
> }
>
sounds a pretty decent name for me.
> > > >
> > > > I'd simply disable it in XFS_DEBUG, once the bug is exactly the same as with non
> > > > debug code, but with a different behavior. Not sure though if there are people
> > > > running xfstests exclusively on XFS_DEBUG.
> > >
> > > I believe running xfstests with XFS_DEBUG is pretty common.
> > >
> >
> > The assert is triggered even before the fixed code can catch the corruption, so,
> > I think if you are not comfortable with it crashing the system, unless we remove
> > the assert from the code (which I believe might be done once the fix is merged),
> > I'de suggest not running this test with XFS_DEBUG.
>
> Yeah, _notrun if XFS_DEBUG is on :)
Sure, I'll add the above helper as a patch before my test, thanks
>
> Thanks,
> Eryu
--
Carlos
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
