Re: [PATCH] xfs/424: add check for crc and finobt

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2017/08/04 22:37, Eric Sandeen wrote:
On 8/4/17 2:20 AM, Xiao Yang wrote:
Hi Eric,

When finobt is disabled, xfs_db gets double crc errors on upstream xfsporgs-dev.
as below(e.g. block size is 4096):
...
xfs_db -c "daddr 16" -c "type finobt" /dev/sda11
Metadata corruption detected at xfs_inobt block 0x10/0x1000
Metadata corruption detected at xfs_inobt block 0x10/0x1000

Is this expected behavor?  Because xfs_db gets one crc error on v4.5 xfsprogs-dev.
as below(e.g. block size is 4096):
...
xfs_db -c "daddr 16" -c "type finobt" /dev/sda11
Metadata CRC error detected at xfs_inobt block 0x10/0x200
So, errors is expected because you finobt is disabled, and you are asking
it to print a not-finobt block as a finobt.

I think the double printing is because upstream the code actually sets
the cursor twice after the commit which tried to fix the type-setting,
it's on my list to fix.
Hi Eric,

Thanks for your detailed explanation, and i got it.
Could you help me review the v2 patch.  Thanks a lot!

Thanks,
Xiao Yang
Thanks,
-Eric

Thanks,
Xiao Yang.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html






--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux