On Thu, Aug 03, 2017 at 08:10:31AM -0400, Brian Foster wrote: > On Thu, Aug 03, 2017 at 12:33:04PM +0800, Eryu Guan wrote: > > Some tests and common helpers don't properly clean up tmp files and > > leave them behind in /tmp dir, and these tmp files are accumulating > > over time. > > > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> > > --- > > v2: > > - fix tmp_dir usage in _mkfs_dev as well > > > > FWIW, there are a couple tests that do 'tmp=$$' instead of 'tmp=/tmp/$$' > as well. I'm not sure how appropriate that is. That aside: Ah, they're generic/436 and generic/445 that I didn't notice in review. Not a big problem but still worth fixing, perhas in another cleanup patch along with other similar fixes (if there're any). > > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> And thanks a lot for all the reviews! Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
