On Wed, Aug 02, 2017 at 12:48:09PM -0300, Ernesto A. Fernández wrote: > On Wed, Aug 02, 2017 at 03:00:30PM +0800, Eryu Guan wrote: > > On Wed, Aug 02, 2017 at 01:19:34AM -0300, Ernesto A. Fernández wrote: > > > > > > +# The content of this file will be used as the value of the attributes > > > +VFILE=$SCRATCH_MNT/valuefile > > > +touch $VFILE > > > +$XFS_IO_PROG -c "pwrite -S 0x2E 0 1k" $VFILE >>$seqres.full 2>&1 > > > + > > > > I think this VFILE is not needed, because .. > > > > > # Try to run out of space so setfacl will fail > > > $XFS_IO_PROG -c "pwrite 0 50m" $TFILE >>$seqres.full 2>&1 > > > i=1 > > > +while $SETFATTR_PROG -n trusted.$i -v $(cat $VFILE) $TFILE &>/dev/null; do > > > > we can use something like $(perl -e 'print "a"x1024') to generate 1k > > attr value. But we can do 60x better than that on xfs, which supports 64k attr values. ext4 is adding support for large values too. I guess the complicated part is having to experimentally determine the maximum attr value size for a given fs and then plugging that in... the gains for which aren't necessarily obvious aside from reducing test runtime. --D > > All right. > > > I can fix it at commit time if this looks OK to you. > > That's great, thanks. > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
