Re: [PATCH] common/rc: add variable MOUNT_OPTIONS into _test_mount

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Jul 31, 2017 at 04:06:33PM +0800, Xiao Yang wrote:
> On RHEL6.9GA, generic/097 fails for ext4 because _test_cycle_mount()
> remount ext4 without the user_xattr option, so extended attributes
> are not supported by ext4.
> 
> On some old kernels, ext4 filesystem can not be mounted with acl and
> user_xattr options by default.  The following patch has enabled these
> options by default:
> 'ea6633369458("ext4: enable acls and user_xattr by default")'
> 
> We add variable MOUNT_OPTIONS into _test_mount, and it works normally
> on all kernels.
> 
> Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx>

MOUNT_OPTIONS is for SCRATCH_DEV, TEST_FS_MOUNT_OPTS is for TEST_DEV, I
think what you should update is _test_mount_opts in common/config, add
something similar to _test_opts for ext series, to add acl and
user_xattr support. Could you please verify if that works?

Thanks,
Eryu

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index c752979..c478eeb 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -519,7 +519,7 @@ _test_mount()
>          return $?
>      fi
>      _test_options mount
> -    _mount -t $FSTYP $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR
> +    _mount -t $FSTYP $TEST_OPTIONS $TEST_FS_MOUNT_OPTS `_common_dev_mount_options $*` $TEST_DEV $TEST_DIR
>  }
>  
>  _test_unmount()
> -- 
> 1.8.3.1
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux