>> The actual block size is not that important for the purposes of this >> test. However, knowing the block size helps simplifying the test >> because we can hardcode xattr value sizes in the rest of the script. >> I've set block size to 4k in case ext4 default changes in the future. > > In this case, what we generally do is filtering the output and make it > consistent across different block size ext4 filesystems, instead of > hardcoding the block size in test, so we have better test coverage. Got it. I removed the hardcoded sizes. Thanks! -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html