Eryu, thanks for the feedback! >> +# FS QA Test 026 >> +# >> +# Test ea_inode feature. > > Better to have more information about ea_inode feature and what this > case tests here too. Done. >> +_scratch_mkfs_ext4 -O ea_inode -I 256 -b 4096 >/dev/null 2>&1 > > Is 4k block size a hard requirement? If not, then we lose test coverage > for 1k/2k block size ext4, if so, some comments on it would be better. > (and the 256 inode size too). The actual block size is not that important for the purposes of this test. However, knowing the block size helps simplifying the test because we can hardcode xattr value sizes in the rest of the script. I've set block size to 4k in case ext4 default changes in the future. >> + if [[ "$value" != "" ]]; then >> + setfattr -n $name -v "$value" $file > > You can use $SETFATTR_PROG and $GETFATTR_PROG in the test. Done. >> + >> + tmp=$(getfattr --absolute-names --only-values -n $name $file) >> + [[ $tmp == $value ]] || echo "unexpected value returned: $tmp" > > Better to get $tmp and $value quoted with "", otherwise if any value is > empty, it's a bash syntax error. Done. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
