Re: [xfstests PATCH v4] generic: add test of file mode when setfacl fails

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Jul 19, 2017 at 02:51:50AM -0300, Ernesto A. Fernández wrote:
> Check that the group permission bits of a file are not altered when setfacl
> fails. At the time of this patch the test fails for at least ext2, ext4,
> jfs and btrfs.
> 
> The failure in setfacl is induced by filling the device and setting as
> many user attributes to the file as possible. For xfs this is not enough,
> and the test will not run.
> 
> Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@xxxxxxxxx>
> ---
> Changes in v4:
>   - Continue to set attributes even when the filesystem claims to be out of
>     space. With this change the test will now fail for btrfs.
>   - Call _notrun when setfacl succeeds, since no check can be done. As suggested
>     by Eryu Guan. 

Thanks a lot for the update! I've queued it for next fstests update.

Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux