On Thu, Jul 06, 2017 at 10:50:59AM +0800, Eryu Guan wrote:
> On Wed, Jul 05, 2017 at 01:37:54PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> >
> > Commit d55123c080cb ("generic/247: filter out expected XFS warnings for
> > mixed mmap/direct I/O") made generic/247 start explicitly unmounting the
> > scratch device. However, the test doesn't actually use the scratch
> > device, so it will fail if SCRATCH_DEV is undefined. Fix it by
> > unmounting the test device instead.
> >
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> Thanks for the fix! I found this in my review and I remembered I removed
> the _scratch_unmount and updated the comments accordingly at commit
> time, but clearly I didn't.
>
It was removed from generic/095 (maybe by accident?) but not generic/247.
Perhaps it needs to be added back to generic/095?
Eric
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
