On Thu, Jun 29, 2017 at 09:26:10PM -0700, Darrick J. Wong wrote:
> On Fri, Jun 30, 2017 at 12:22:08PM +0800, Eryu Guan wrote:
> > On Thu, Jun 29, 2017 at 09:13:31PM -0700, Darrick J. Wong wrote:
> > > The ext4 online scrub program is no longer under active development,
> > > so remove all the test code that tried to use it.
> > >
> > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > > ---
> > > common/fuzzy | 2 +-
> > > tests/ext4/023 | 1 -
> > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/common/fuzzy b/common/fuzzy
> > > index 304268e..686cf77 100644
> > > --- a/common/fuzzy
> > > +++ b/common/fuzzy
> > > @@ -70,7 +70,7 @@ _require_scrub() {
> > > # Scrub the scratch filesystem metadata (online)
> > > _scratch_scrub() {
> > > case "${FSTYP}" in
> > > - "xfs"|"ext4"|"ext3"|"ext2")
> > > + "xfs")
> > > $XFS_SCRUB_PROG -d -T -v "$@" $SCRATCH_MNT
> > > ;;
> > > *)
> > > diff --git a/tests/ext4/023 b/tests/ext4/023
> > > index 4f5cf3e..4491936 100755
> > > --- a/tests/ext4/023
> > > +++ b/tests/ext4/023
> > > @@ -53,7 +53,6 @@ _scratch_populate_cached > $seqres.full 2>&1
> > >
> > > echo "Scrub"
> > > _scratch_mount >> $seqres.full 2>&1
> > > -_scratch_scrub >> $seqres.full
> >
> > Just a quick glance at this one, shouldn't ext4/023 be removed? If
> > _scratch_scrub is removed from the test, all the test does is populating
> > the fs and mount and pass.
>
> I've been using it to verify that we can create ext4 filesystems with all
> known types of metadata, and that we can actually capture metadata images
> of such a filesystem.
Then the test descriptions should be updated too, it no longer matches
what the test does. And 'echo "Scrub"' then just mounts the fs is
confusing too :)
Thanks,
Eryu
>
> > And I think _require_scrub should be updated too to remove ext4 support.
>
> oops, yes.
>
> --D
>
> >
> > Thanks,
> > Eryu
> >
> > >
> > > # success, all done
> > > status=0
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
