Re: [PATCH 2/2] common: remove tmp.mkfs[err/std] files by name

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, 27 Jun 2017 12:33:04 +0800, Eryu Guan wrote:

> I posted a patch back in Jan. to cleanup tmp files and other leftover
> files after test, I switched from mktemp to a normal "tmp=/tmp/$$._mkfs"
> assignment so it could avoid this problem you want to fix too. But my
> patch got no review.
> 
> I'm going to send new version of my patch and will fix _scratch_do_mkfs
> too, I really appreciate if you could help review and provide
> Reviewed-by tag.

Thanks for the feedback, Eryu. My preference would be to continue to use
mktemp. I know it's test code, but I'd still like to avoid any potential
symlink races.

Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux