Re: [PATCH] generic: test Btrfs delalloc accounting overflow

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Jun 02, 2017 at 12:07:37PM +0300, Nikolay Borisov wrote:
> > +# Make sure that we didn't leak any metadata space.
> > +if [[ $FSTYP = btrfs ]]; then
> > +	uuid="$(findmnt -n -o UUID "$TEST_DIR")"
> 
> if we are on btrfs and we don't have findmnt this test will likely fail.
> Perhaps include a _require_command findmnt

I think utilities like findmnt should be checked at the beginning of the
whole testuiste, not in each test that uses them. As findmnt is part of
util-linux, missing it would also mean that eg 'mount' is missing.
Highly unlikely.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux