On 2017/05/16 16:16, Amir Goldstein wrote:
On Mon, May 15, 2017 at 10:17 AM, Xiao Yang<yangx.jy@xxxxxxxxxxxxxx> wrote:
We could remove _require_fiemap and _require_fiemap_attr.
We COULD remove it but why SHOULD we?
Hi Amir
Sorry for my lack of explanation, this is just a cleanup for growing
unnecessary helper.
_require_fiemap and _require_xfs_io_command "fiemap" do the same thing, but i find that
some test cases use the former and some use the latter, i feel they shoud be unified.
Moreover, the number of helpers like this is slowly growing, but it's easy to simply use
_require_xfs_io_command directly and just specify the command we want to check.
If it is acceptable, then i will rewrite the commit message and send a v2.
Thanks,
Xiao Yang
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
