On 2017/04/25 21:09, Eryu Guan wrote: > On Wed, Apr 19, 2017 at 04:33:48PM -0700, Gwendal Grignou wrote: >> - Request LIBTOOL to be used >> - Set topbuildir based on a Makefile variable to call libtool >> - Use /usr/local instead of /var for xfstest final location >> - Move macros from aclocal.m4 to acinclude.m4, aclocal.m4 is autogenerated. >> - Use autoconf variables @prefix@, @exec_prefix@. >> >> The regular way of compiling xfstests - make - remains. >> But it now runs autoreconf and libtoolize -i to produce a valid >> configure. >> Verified with 'make install --dry-run' that files are installed at the >> same place. >> Verified compiling in chromeOS chroot works as well. >> >> Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> >> --- >> >> Changes in v2: >> Removal of instal-sh, use of autoreconf >> >> Changes in v3: >> Use of @exec_prefix@ variable, unify installation location. >> >> Changes in v4: >> Add --install option to autoreconf so that aclocal is called with -I m4. >> Keep using AC_CONFIG_MACRO_DIR when autoconf is called directly. >> With --install option and AC_CONFIG_MACRO_DIR undefined verify that configure >> still works. > Thanks a lot for the update! v4 works for me too with RHEL6, RHEL7 and > Fedora 25 hosts. > Hi Eryu When appling v4 patch, i still got the following error messgae on RHEL6.9GA: ============================================================================ [root@RHEL6U9GA_Intel64 xfstests]# make autoreconf --include=m4 configure.ac:5: error: possibly undefined macro: AC_PACKAGE_GLOBALS If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:6: error: possibly undefined macro: AC_PACKAGE_UTILITIES configure.ac:43: error: possibly undefined macro: AC_PACKAGE_NEED_UUIDCOMPARE configure.ac:48: error: possibly undefined macro: AC_PACKAGE_NEED_SYS_ACL_H configure.ac:49: error: possibly undefined macro: AC_PACKAGE_NEED_ATTRIBUTES_H configure.ac:50: error: possibly undefined macro: AC_PACKAGE_WANT_NDBM configure.ac:51: error: possibly undefined macro: AC_PACKAGE_NEED_IRIX_LIBHANDLE configure.ac:56: error: possibly undefined macro: AC_MULTILIB configure.ac:57: error: possibly undefined macro: AC_PACKAGE_NEED_XFS_XFS_H configure.ac:58: error: possibly undefined macro: AC_PACKAGE_WANT_LIBXFS_H configure.ac:59: error: possibly undefined macro: AC_PACKAGE_WANT_XLOG_ASSIGN_LSN configure.ac:60: error: possibly undefined macro: AC_PACKAGE_NEED_XFS_XQM_H configure.ac:61: error: possibly undefined macro: AC_PACKAGE_NEED_XFSCTL_MACRO configure.ac:62: error: possibly undefined macro: AC_PACKAGE_NEED_XFS_HANDLE_H configure.ac:64: error: possibly undefined macro: AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE configure.ac:65: error: possibly undefined macro: AC_PACKAGE_NEED_ATTR_XATTR_H configure.ac:67: error: possibly undefined macro: AC_PACKAGE_WANT_ATTRLIST_LIBATTR configure.ac:68: error: possibly undefined macro: AC_PACKAGE_NEED_GETXATTR_LIBATTR configure.ac:71: error: possibly undefined macro: AC_PACKAGE_NEED_ACL_LIBACL_H configure.ac:72: error: possibly undefined macro: AC_PACKAGE_NEED_ACLINIT_LIBACL configure.ac:74: error: possibly undefined macro: AC_PACKAGE_WANT_GDBM configure.ac:75: error: possibly undefined macro: AC_PACKAGE_WANT_AIO configure.ac:76: error: possibly undefined macro: AC_PACKAGE_WANT_DMAPI configure.ac:82: error: possibly undefined macro: AC_PACKAGE_WANT_SSL autoreconf: /usr/bin/autoconf failed with exit status: 1 make: *** [configure] Error 1 [root@RHEL6U9GA_Intel64 xfstests]# uname -r 2.6.32-696.el6.x86_64 [root@RHEL6U9GA_Intel64 ~]# rpm -q automake autoconf m4 libtool automake-1.11.1-4.el6.noarch autoconf-2.63-5.1.el6.noarch m4-1.4.13-5.el6.x86_64 libtool-2.2.6-15.5.el6.x86_64 ============================================================================ autoreconf with --include m4 may not fix undefined macro on RHEL6.9GA, do you have the same issue? Thanks, Xiao Yang > If all the following changes look OK to you and there're no new comments > from other reviewers on the list, I'm going to push this patch to > upstream this week. So please shout out loud if anyone has any complains :) > (new patch attached) > > First, I updated the patch a bit to resolve the merge conflicts with > commit b34b378 src/open_by_handle: program to exercise > open_by_handle_at() syscall, added open_by_handle_at detection in > acinclude.m4 > >> Makefile | 7 +- >> acinclude.m4 | 30 ++++++ >> aclocal.m4 | 50 ---------- >> configure.ac | 3 +- >> include/builddefs.in | 9 +- >> install-sh | 259 --------------------------------------------------- >> 6 files changed, 41 insertions(+), 317 deletions(-) >> create mode 100644 acinclude.m4 >> delete mode 100644 aclocal.m4 >> delete mode 100755 install-sh >> >> diff --git a/Makefile b/Makefile >> index 30d8747d..d41750ab 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -76,12 +76,13 @@ clean: # if configure hasn't run, nothing to clean >> endif >> >> configure: configure.ac >> - autoheader >> - autoconf >> + autoreconf --include=m4 >> + libtoolize -i > Second. This creates some new untracked files, I'd like to add them to > .gitignore too and remove them by running "make realclean", so I made > the following changes. > > --- a/.gitignore > +++ b/.gitignore > @@ -9,10 +9,23 @@ > /results > > # autoconf generated files > +/aclocal.m4 > /autom4te.cache > /configure > +/config.guess > /config.log > /config.status > +/config.sub > +/m4/libtool.m4 > +/m4/ltoptions.m4 > +/m4/ltsugar.m4 > +/m4/ltversion.m4 > +/m4/lt~obsolete.m4 > + > +# libtool > +/libtool > +/install-sh > +/ltmain.sh > > # build system > /include/builddefs > diff --git a/Makefile b/Makefile > index 30d8747..ebf5c03 100644 > --- a/Makefile > +++ b/Makefile > @@ -41,10 +41,13 @@ endif > > SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz > > -CONFIGURE = configure include/builddefs include/config.h > +CONFIGURE = configure include/builddefs include/config.h \ > + aclocal.m4 config.guess config.sub install-sh ltmain.sh \ > + m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \ > + m4/lt~obsolete.m4 > LSRCFILES = configure configure.ac aclocal.m4 README VERSION > LDIRT = config.log .ltdep .dep config.status config.cache confdefs.h \ > - conftest* check.log check.time > + conftest* check.log check.time libtool > > ifeq ($(HAVE_BUILDDEFS), yes) > LDIRT += $(SRCTAR) > > > Thanks again! > > Eryu > > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
