Re: [PATCH] kvm-xfstests: fix running tests with non-primary filesystem type

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, May 01, 2017 at 10:03:58AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> With kvm-xfstests, the 'setup-fstab' script would add entries for the
> test devices to /etc/fstab, using $PRIMARY_FSTYPE (default "ext4").
> This was apparently intended only as a convenience to allow manually
> running commands like 'mount /vdb'.  However, it was actually always
> executed because the appliance is configured to automatically start
> interactive login shells for 'root' on the extra serial ports.  This
> broke running tests with filesystem types other than the "primary",
> since the wrong fsck program would run.
> 
> To fix this, instead use static fstab entries with fstype 'auto'.  This
> makes fsck and mount auto-detect the filesystem type, so both the tests
> and interactive mounts will work regardless of filesystem type.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux