Re: [PATCH v2] fstests/xfs: xfs_repair should junk empty attribute leaf blocks

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]




On 4/12/17 10:39 AM, Zorro Lang wrote:
> +# This repair should junk above leaf attribute and fix this XFS, then
> +# SCRATCH_DEV shouldn't be corrupted after this case done.
> +_repair_scratch_fs >> $seqres.full
> +
> +echo "Silence is golden"
> +

as mentioned on IRC, I don't think you have any validation here.

If you are running with an xfs_repair that does not find the corruption,
then neither the repair above nor the post-test xfs_repair -n will
find any problems, and the test will incorrectly pass.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux