On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@xxxxxxxxxx wrote: > From: Filipe Manana <fdmanana@xxxxxxxx> > > For example NFS 4.2 supports fallocate but it does not support its > KEEP_SIZE flag, so we want to skip tests that use fallocate with that > flag on filesystems that don't support it. > > Suggested-by: Eryu Guan <eguan@xxxxxxxxxx> > Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> > --- > common/rc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/rc b/common/rc > index e1ab2c6..3d0f089 100644 > --- a/common/rc > +++ b/common/rc > @@ -2021,8 +2021,8 @@ _require_xfs_io_command() > "chproj") > testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` > ;; > - "falloc" ) > - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` > + "falloc*" ) > + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` Sorry, I was wrong about this. It would break the subsequent $XFS_IO_PROG -c "help $command" | grep ... command if another $param is specified. Seems adding $param to falloc command is the right way, as what Darrick did to fiemap in his new test. - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` + testio=`$XFS_IO_PROG -F -f -c "falloc $param 0 1m" $testfile 2>&1` Do you mind me updating these three patches accordingly? Or can you send out new version if you like? Thanks! And sorry again! Eryu P.S. I'm thinking of converting all the case switches (except the default one) in _require_xfs_io_command() to actually run the $command with $param, and doing other cleanups, but that won't block this patch and I can do it in another patch. > ;; > "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") > testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ > -- > 2.7.0.rc3 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
