On Thu, Apr 6, 2017 at 3:18 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > On Tue, Apr 04, 2017 at 07:34:29AM +0100, fdmanana@xxxxxxxxxx wrote: >> From: Filipe Manana <fdmanana@xxxxxxxx> >> >> For example NFS 4.2 supports fallocate but it does not support its >> KEEP_SIZE flag, so we want to skip tests that use fallocate with that >> flag on filesystems that don't support it. >> >> Suggested-by: Eryu Guan <eguan@xxxxxxxxxx> >> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> >> --- >> common/rc | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/common/rc b/common/rc >> index e1ab2c6..3d0f089 100644 >> --- a/common/rc >> +++ b/common/rc >> @@ -2021,8 +2021,8 @@ _require_xfs_io_command() >> "chproj") >> testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1` >> ;; >> - "falloc" ) >> - testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1` >> + "falloc*" ) > > This doesn't work as expected with quotes. I can remove the quotes at > commit time though. Hum, it did work for me, strange. But please do, thanks. > > Thanks, > Eryu > >> + testio=`$XFS_IO_PROG -F -f -c "$command 0 1m" $testfile 2>&1` >> ;; >> "fpunch" | "fcollapse" | "zero" | "fzero" | "finsert" | "funshare") >> testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ >> -- >> 2.7.0.rc3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe fstests" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
