Re: [PATCH 4/4] xfstests: Check the stx_attributes settable by chattr [ver #3]

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Apr 4, 2017 at 12:17 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
> David Howells <dhowells@xxxxxxxxxx> wrote:
>
>> Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote:
>>
>> ...
>> > If so, perhaps there should be separate tests for each of the 4 attrs.
>>
>> They should also be tested in combination.  Hmmm...
>
> Hmmm...  It appears that that would require 16 separate test files, each with
> the appropriate combination of "_require_chattr <letter>".
>

I don't think that is necessary.

IMO, _require_chattr <letter> means test cannot run without this,
so no use in running it.
This is not true for this test.

Since this test is expecting empty output its not even hard to change the test.

First try silently all the 4 letters.
Then iterate of combination of supported subset.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux