On Tue, Mar 21, 2017 at 5:18 AM, Zorro Lang <zlang@xxxxxxxxxx> wrote: > The output of x/068 will be perturbed by new fsstress operations. > For keep away breaking x/068's golden image, skip mread and > mwrite which are brought in by a new fsstress patch. > > Reported-by: Eryu Guan <eguan@xxxxxxxxxx> > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > --- > tests/xfs/068 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/xfs/068 b/tests/xfs/068 > index 4dac95e..568ba60 100755 > --- a/tests/xfs/068 > +++ b/tests/xfs/068 > @@ -44,7 +44,7 @@ _supported_fs xfs > _supported_os Linux > > # need to ensure new fsstress operations don't perturb expected output > -FSSTRESS_AVOID="-f insert=0 $FSSTRESS_AVOID" > +FSSTRESS_AVOID="-f insert=0 -f mwrite=0 -f mread=0 $FSSTRESS_AVOID" What?? This is so fragile! If the test wanted to restrict fsstress to a pre-defined set of operations, then _create_dumpdir_stress_num() should have prefixed '_param' with -z and mention all pre-defined ops (and not only the more frequent ones). I am very surprised that Dave was the one that made this bandaid. Eric, Can you say if adding -z to _create_dumpdir_stress_num() params would be fine with the 2 tests that use it - xfs/022 and xfs/068? 068 output would have to be fixed to accommodate this change, but then we can remove the bandaid above and never think of this ever again. > _create_dumpdir_stress_num 4096 > _do_dump_restore > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
