Re: [PATCH] generic/397: test renaming encrypted files without key

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Mar 15, 2017 at 05:39:42PM +0800, Eryu Guan wrote:
> On Tue, Mar 14, 2017 at 02:23:58PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> > 
> > Update generic/397 to test another behavior when accessing encrypted
> > files without the key: renames should be forbidden, even though they may
> > be possible cryptographically.  Test both a regular rename and a cross
> > rename.  (It happens that generic/398 also covers the cross rename case,
> > but it's primarily for a different reason.)
> > 
> > Cc: Theodore Ts'o <tytso@xxxxxxx>
> > Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> > Cc: Richard Weinberger <richard@xxxxxx>
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> We usually don't add new tests to existing tests, expecially targeted
> regression tests, this could make test start failing and make people
> think it's a new regression.
> 
> Would you mind writing a new case for it?
> 
> Thanks,
> Eryu

I felt that this fit well into the existing test, but yes I'll add a new one if
that's preferable.  Thanks!

- Eric
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux